do we have one?

This commit is contained in:
Dengke Tang
2022-11-07 16:30:48 -08:00
parent bc62e20f78
commit 2c3296004f
+86 -88
View File
@@ -14,78 +14,78 @@ env:
RUN: ${{ github.run_id }}-${{ github.run_number }} RUN: ${{ github.run_id }}-${{ github.run_number }}
jobs: jobs:
php-5_5-linux-x64: # php-5_5-linux-x64:
name: php-linux-x64 (5.5) # name: php-linux-x64 (5.5)
runs-on: ubuntu-latest # runs-on: ubuntu-latest
steps: # steps:
- name: Setup PHP with Xdebug # - name: Setup PHP with Xdebug
uses: shivammathur/setup-php@v2 # uses: shivammathur/setup-php@v2
with: # with:
coverage: xdebug # coverage: xdebug
php-version: 5.5 # php-version: 5.5
ini-values: xdebug.overload_var_dump=0, memory_limit=4G, phar.readonly=false # ini-values: xdebug.overload_var_dump=0, memory_limit=4G, phar.readonly=false
- name: Checkout # - name: Checkout
uses: actions/checkout@v2 # uses: actions/checkout@v2
with: # with:
submodules: recursive # submodules: recursive
- name: Install ancient PHPUnit # - name: Install ancient PHPUnit
run: composer require --dev --ignore-platform-reqs phpunit/phpunit "4.8.36" # run: composer require --dev --ignore-platform-reqs phpunit/phpunit "4.8.36"
- name: Install dependencies # - name: Install dependencies
run: composer update --no-interaction # run: composer update --no-interaction
- name: Build for PHP 5.5 # - name: Build for PHP 5.5
env: # env:
CC: clang # CC: clang
CXX: clang++ # CXX: clang++
run: | # run: |
phpize # phpize
./configure # ./configure
make # make
php-linux-x64: # php-linux-x64:
runs-on: ubuntu-latest # runs-on: ubuntu-latest
strategy: # strategy:
fail-fast: false # fail-fast: false
matrix: # matrix:
version: # version:
- "5.6" # - "5.6"
- "7.0" # - "7.0"
- "7.1" # - "7.1"
- "7.2" # - "7.2"
- "7.3" # - "7.3"
- "7.4" # - "7.4"
- "8.0" # - "8.0"
steps: # steps:
- name: Setup PHP with Xdebug # - name: Setup PHP with Xdebug
uses: shivammathur/setup-php@v2 # uses: shivammathur/setup-php@v2
with: # with:
coverage: xdebug # coverage: xdebug
php-version: ${{matrix.version}} # php-version: ${{matrix.version}}
ini-values: xdebug.overload_var_dump=0, memory_limit=4G, phar.readonly=false # ini-values: xdebug.overload_var_dump=0, memory_limit=4G, phar.readonly=false
- name: Checkout # - name: Checkout
uses: actions/checkout@v2 # uses: actions/checkout@v2
with: # with:
submodules: recursive # submodules: recursive
- name: Install dependencies # - name: Install dependencies
run: composer update --no-interaction # run: composer update --no-interaction
- name: Run tests # - name: Run tests
env: # env:
CC: clang # CC: clang
CXX: clang++ # CXX: clang++
run: | # run: |
phpize # phpize
./configure # ./configure
make # make
make test # make test
# linux-arm: # # linux-arm:
# name: ARM (${{ matrix.arch }}) # name: ARM (${{ matrix.arch }})
# runs-on: ubuntu-latest # runs-on: ubuntu-latest
# strategy: # strategy:
@@ -114,31 +114,29 @@ jobs:
php-version: '8.0' php-version: '8.0'
- name: Build ${{ env.PACKAGE_NAME }} + consumers - name: Build ${{ env.PACKAGE_NAME }} + consumers
run: | run: |
cd ..\ composer.phar
git clone https://github.com/Microsoft/php-sdk-binary-tools.git php-sdk
.\php-sdk\phpsdk-vs16-x64.bat -t .\aws-crt-php\win_build.bat --task-args %CD%\aws-crt-php
macos: # macos:
runs-on: macos-${{ matrix.version }} # runs-on: macos-${{ matrix.version }}
strategy: # strategy:
matrix: # matrix:
version: [10.15] # version: [10.15]
steps: # steps:
# Force PHP to 8.0 # # Force PHP to 8.0
# Doing this because tests fail in PHP 8.1 (default on macos Github Runner as of Dec 2021) # # Doing this because tests fail in PHP 8.1 (default on macos Github Runner as of Dec 2021)
# due to the old version of PHPUnit we're using. # # due to the old version of PHPUnit we're using.
# We're using an old PHPUnit because it's compatible our min supported PHP 5.5. # # We're using an old PHPUnit because it's compatible our min supported PHP 5.5.
# Quick fix is to force PHP version back to 8.0, which can still run our tests without error. # # Quick fix is to force PHP version back to 8.0, which can still run our tests without error.
# A real solution is to get our tests working on all PHP versions # # A real solution is to get our tests working on all PHP versions
# (maybe don't use PHPUnit, maybe raise our min supported PHP version so we can upgrade, # # (maybe don't use PHPUnit, maybe raise our min supported PHP version so we can upgrade,
# or maybe use PHPUnit-Polyfills so we can use a modern PHPUnit with old PHP) # # or maybe use PHPUnit-Polyfills so we can use a modern PHPUnit with old PHP)
- name: Setup PHP 8.0 # - name: Setup PHP 8.0
uses: shivammathur/setup-php@v2 # uses: shivammathur/setup-php@v2
with: # with:
php-version: '8.0' # php-version: '8.0'
- name: Build PHP 8 extension and test # - name: Build PHP 8 extension and test
run: | # run: |
python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder')" # python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder')"
chmod a+x builder # chmod a+x builder
./builder build -p ${{ env.PACKAGE_NAME }} --spec=downstream # ./builder build -p ${{ env.PACKAGE_NAME }} --spec=downstream