try this out

2026-08-18 01:57:13 +00:00 · 2023-02-27 15:36:28 -08:00
parent 7121cef4a6
commit 5184a70c16
2 changed files with 43 additions and 56 deletions
@@ -142,48 +142,48 @@ jobs:
  #       python -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder.pyz')"
  #       python builder.pyz build -p ${{ env.PACKAGE_NAME }} downstream

-  macos:
-    runs-on: macos-${{ matrix.version }}
-    strategy:
-      matrix:
-        version: [10.15]
-    steps:
-      # Force PHP to 8.0
-      # Doing this because tests fail in PHP 8.1 (default on macos Github Runner as of Dec 2021)
-      # due to the old version of PHPUnit we're using.
-      # We're using an old PHPUnit because it's compatible our min supported PHP 5.5.
-      # Quick fix is to force PHP version back to 8.0, which can still run our tests without error.
-      # A real solution is to get our tests working on all PHP versions
-      # (maybe don't use PHPUnit, maybe raise our min supported PHP version so we can upgrade,
-      # or maybe use PHPUnit-Polyfills so we can use a modern PHPUnit with old PHP)
-      - name: Setup PHP 8.0
-        uses: shivammathur/setup-php@v2
-        with:
-          php-version: '8.0'
-      - name: Build PHP 8 extension and test
-        run: |
-          python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder')"
-          chmod a+x builder
-          ./builder build -p ${{ env.PACKAGE_NAME }} --spec=downstream
+  # macos:
+  #   runs-on: macos-${{ matrix.version }}
+  #   strategy:
+  #     matrix:
+  #       version: [10.15]
+  #   steps:
+  #     # Force PHP to 8.0
+  #     # Doing this because tests fail in PHP 8.1 (default on macos Github Runner as of Dec 2021)
+  #     # due to the old version of PHPUnit we're using.
+  #     # We're using an old PHPUnit because it's compatible our min supported PHP 5.5.
+  #     # Quick fix is to force PHP version back to 8.0, which can still run our tests without error.
+  #     # A real solution is to get our tests working on all PHP versions
+  #     # (maybe don't use PHPUnit, maybe raise our min supported PHP version so we can upgrade,
+  #     # or maybe use PHPUnit-Polyfills so we can use a modern PHPUnit with old PHP)
+  #     - name: Setup PHP 8.0
+  #       uses: shivammathur/setup-php@v2
+  #       with:
+  #         php-version: '8.0'
+  #     - name: Build PHP 8 extension and test
+  #       run: |
+  #         python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder')"
+  #         chmod a+x builder
+  #         ./builder build -p ${{ env.PACKAGE_NAME }} --spec=downstream

-  pecl-package-test:
-    runs-on: ubuntu-latest
-    steps:
-    - name: Setup PHP
-      uses: shivammathur/setup-php@v2
-      with:
-        php-version: '8.0'
+  # pecl-package-test:
+  #   runs-on: macos-latest
+  #   steps:
+  #   - name: Setup PHP
+  #     uses: shivammathur/setup-php@v2
+  #     with:
+  #       php-version: '8.0'

-    - name: Checkout
-      uses: actions/checkout@v2
-      with:
-        submodules: recursive
+  #   - name: Checkout
+  #     uses: actions/checkout@v2
+  #     with:
+  #       submodules: recursive

-    - name: Test PECL package build
-      run: |
-        python3 dev-scripts/prepare_pecl_release.py --name aws-crt --user aws-crt --version 1.0.0
-        tar -zxf *.tgz
-        cd awscrt-1.0.0
-        phpize
-        ./configure
-        make
+  #   - name: Run tests
+  #     run: |
+  #       ./dev-scripts/prepare_release.sh --name aws-crt --user aws-crt --email [email protected] --version 1.0.0 --notes NOTES
+  #       tar -zxf *.tgz
+  #       cd awscrt-1.0.0
+  #       phpize
+  #       ./configure
+  #       make