mirrors/awslabs_aws-crt-php
1
0
Fork 0
mirror of https://github.com/awslabs/aws-crt-php.git synced 2026-08-18 10:07:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Idiomatic fixes from previous PRs (#20)

Browse Source 
* Various idiomatic feedback from PHP team

* Additional fixes after debugging tests
This commit is contained in:
Justin Boswell
2021-03-25 15:13:23 -04:00
committed by GitHub
parent 9c9422c21f
commit 531330e1b2
4 changed files with 14 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/AWS/CRT/HTTP/Message.php
+3 -4
View File
@@ -3,7 +3,6 @@
namespace AWS\CRT\HTTP;
use AWS\CRT\NativeResource;
use AWS\CRT\Internal\Encoding;
abstract class Message extends NativeResource {
@@ -12,11 +11,11 @@ abstract class Message extends NativeResource {
private $query;
private $headers;
public function __construct($method, $path, $query = [], $headers = null) {
public function __construct($method, $path, $query = [], $headers = []) {
$this->method = $method;
$this->path = $path;
$this->query = $query;
$this->headers = !is_null($headers) ? $headers : new Headers();
$this->headers = new Headers($headers);
$this->acquire(self::$crt->http_message_new_from_blob(self::marshall($this)));
}
@@ -54,7 +53,7 @@ abstract class Message extends NativeResource {
$query = [];
}
return new $class($method, $path, $query, $headers);
return new $class($method, $path, $query, $headers->toArray());
}
public function pathAndQuery() {