From c1512f9c7080a8a32ba82a55e6f48d04313f7c30 Mon Sep 17 00:00:00 2001 From: Dengke Tang Date: Tue, 28 Feb 2023 15:37:19 -0800 Subject: [PATCH] address comments --- Makefile.frag | 1 - Makefile.frag.w32 | 2 +- README.md | 5 +++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile.frag b/Makefile.frag index 80d636a..a1414a7 100644 --- a/Makefile.frag +++ b/Makefile.frag @@ -21,7 +21,6 @@ CMAKE_CONFIGURE = $(CMAKE) \ -DCMAKE_INSTALL_PREFIX=$(INT_DIR) \ -DBUILD_TESTING=OFF \ -DCMAKE_BUILD_TYPE=$(CMAKE_BUILD_TYPE) \ - -DCMAKE_CXX_COMPILER_FORCED=True \ $(CMAKE_USE_OPENSSL) \ $(CMAKE_PREFIX_PATH) CMAKE_BUILD = CMAKE_BUILD_PARALLEL_LEVEL='' $(CMAKE) --build diff --git a/Makefile.frag.w32 b/Makefile.frag.w32 index 8c53de1..441abcd 100644 --- a/Makefile.frag.w32 +++ b/Makefile.frag.w32 @@ -2,7 +2,7 @@ CMAKE=cmake.exe PHP_BINARY=$(PHP_PREFIX)\php.exe -CMAKE_CONFIGURE = $(CMAKE) -DCMAKE_INSTALL_PREFIX=$(AWSCRT_DIR)\build\install -DCMAKE_PREFIX_PATH=$(AWSCRT_DIR)\build\install -DBUILD_TESTING=OFF -DCMAKE_BUILD_TYPE=$(CMAKE_BUILD_TYPE) -DCMAKE_CXX_COMPILER_FORCED=True +CMAKE_CONFIGURE = $(CMAKE) -DCMAKE_INSTALL_PREFIX=$(AWSCRT_DIR)\build\install -DCMAKE_PREFIX_PATH=$(AWSCRT_DIR)\build\install -DBUILD_TESTING=OFF -DCMAKE_BUILD_TYPE=$(CMAKE_BUILD_TYPE) CMAKE_BUILD = $(CMAKE) --build CMAKE_BUILD_TYPE = Release CMAKE_TARGET = --config $(CMAKE_BUILD_TYPE) --target install diff --git a/README.md b/README.md index ee7fb40..f8f3691 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ * GCC 4.4+, clang 3.8+ on UNIX, Visual Studio build tools on Windows * Tests require [Composer](https://getcomposer.org) -## Installation +## Installing with Composer and PECL The package has two different package published to [composer](https://packagist.org/packages/aws/aws-crt-php) and [PECL](https://pecl.php.net/package/awscrt). @@ -23,7 +23,8 @@ On Windows, you need to build from source as instruction written below for the n composer require aws/aws-crt-php ``` -## Building on UNIX +## Building from Github source + ```sh $ git clone --recursive https://github.com/awslabs/aws-crt-php.git $ cd aws-crt-php