mirrors/awslabs_aws-crt-php
1
0
Fork 0
mirror of https://github.com/awslabs/aws-crt-php.git synced 2026-08-18 18:13:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

what's the version

Browse Source
This commit is contained in:
Dengke Tang
2022-11-08 09:31:23 -08:00
parent 36354dc333
commit d49eaad553
3 changed files with 27 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/ci.yml
+23 -23
View File
@@ -120,26 +120,26 @@ jobs:
.\php-sdk\phpsdk-vs16-x64.bat -t .\aws-crt-php\win_build.bat --task-args %CD%\aws-crt-php
# macos:
# runs-on: macos-${{ matrix.version }}
# strategy:
# matrix:
# version: [10.15]
# steps:
# # Force PHP to 8.0
# # Doing this because tests fail in PHP 8.1 (default on macos Github Runner as of Dec 2021)
# # due to the old version of PHPUnit we're using.
# # We're using an old PHPUnit because it's compatible our min supported PHP 5.5.
# # Quick fix is to force PHP version back to 8.0, which can still run our tests without error.
# # A real solution is to get our tests working on all PHP versions
# # (maybe don't use PHPUnit, maybe raise our min supported PHP version so we can upgrade,
# # or maybe use PHPUnit-Polyfills so we can use a modern PHPUnit with old PHP)
# - name: Setup PHP 8.0
# uses: shivammathur/setup-php@v2
# with:
# php-version: '8.0'
# - name: Build PHP 8 extension and test
# run: |
# python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder')"
# chmod a+x builder
# ./builder build -p ${{ env.PACKAGE_NAME }} --spec=downstream
macos:
runs-on: macos-${{ matrix.version }}
strategy:
matrix:
version: [10.15]
steps:
# Force PHP to 8.0
# Doing this because tests fail in PHP 8.1 (default on macos Github Runner as of Dec 2021)
# due to the old version of PHPUnit we're using.
# We're using an old PHPUnit because it's compatible our min supported PHP 5.5.
# Quick fix is to force PHP version back to 8.0, which can still run our tests without error.
# A real solution is to get our tests working on all PHP versions
# (maybe don't use PHPUnit, maybe raise our min supported PHP version so we can upgrade,
# or maybe use PHPUnit-Polyfills so we can use a modern PHPUnit with old PHP)
- name: Setup PHP 8.0
uses: shivammathur/setup-php@v2
with:
php-version: '8.0'
- name: Build PHP 8 extension and test
run: |
python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder')"
chmod a+x builder
./builder build -p ${{ env.PACKAGE_NAME }} --spec=downstream