From 4d1a808f18b3bf0e6ed2a1776ed3e98075d1c291 Mon Sep 17 00:00:00 2001
From: Jaapio <jaap@ijaap.nl>
Date: Sat, 27 Jun 2020 13:18:16 +0200
Subject: [PATCH] Bump qa tools

---
 .github/workflows/push.yml          | 20 ++++++++++----------
 Makefile                            |  6 +++---
 phive.xml                           |  1 +
 src/DocBlock/StandardTagFactory.php |  2 ++
 4 files changed, 16 insertions(+), 13 deletions(-)

diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml
index f752b3b..c9a1c1e 100644
--- a/.github/workflows/push.yml
+++ b/.github/workflows/push.yml
@@ -8,7 +8,7 @@ jobs:
   setup:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v2
 
       - name: Restore/cache tools folder
         uses: actions/cache@v1
@@ -44,7 +44,7 @@ jobs:
     name: Unit tests
     needs: setup
     steps:
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v2
 
       - name: composer
         uses: docker://composer
@@ -80,7 +80,7 @@ jobs:
       - phpunit-with-coverage
 
     steps:
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v2
 
       - name: Setup cache environment
         id: cache-env
@@ -97,7 +97,7 @@ jobs:
           key: ${{ steps.cache-env.outputs.key }}
 
       - name: Setup PHP
-        uses: shivammathur/setup-php@master
+        uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php-versions }}
           extension: ${{ env.extensions }}
@@ -134,7 +134,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: [setup, phpunit]
     steps:
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v2
       - name: Restore/cache vendor folder
         uses: actions/cache@v1
         with:
@@ -144,7 +144,7 @@ jobs:
             all-build-${{ hashFiles('**/composer.lock') }}
             all-build-
       - name: Code style check
-        uses: phpDocumentor/coding-standard@master
+        uses: phpDocumentor/coding-standard@latest
         with:
           args: -s
 
@@ -152,7 +152,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: [setup, phpunit]
     steps:
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v2
       - name: composer
         uses: docker://composer
         env:
@@ -184,7 +184,7 @@ jobs:
       - phpunit
 
     steps:
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v2
 
       - name: Setup cache environment
         id: cache-env
@@ -201,7 +201,7 @@ jobs:
           key: ${{ steps.cache-env.outputs.key }}
 
       - name: Setup PHP
-        uses: shivammathur/setup-php@master
+        uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php-versions }}
           extension: ${{ env.extensions }}
@@ -231,7 +231,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: [setup, phpunit]
     steps:
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v2
       - name: fetch tags
         run: git fetch --depth=1 origin +refs/tags/*:refs/tags/*
       - name: BC Check
diff --git a/Makefile b/Makefile
index 355191f..5aff03e 100644
--- a/Makefile
+++ b/Makefile
@@ -13,11 +13,11 @@ setup: install-phive
 
 .PHONY: phpcs
 phpcs:
-	docker run -it --rm -v${PWD}:/opt/project -w /opt/project phpdoc/phpcs-ga:v1.0.0 -s
+	docker run -it --rm -v${PWD}:/opt/project -w /opt/project phpdoc/phpcs-ga:latest -s
 
 .PHONY: phpcbf
 phpcbf:
-	docker run -it --rm -v${PWD}:/opt/project -w /opt/project phpdoc/phpcs-ga:v1.0.0 phpcbf
+	docker run -it --rm -v${PWD}:/opt/project -w /opt/project phpdoc/phpcs-ga:latest phpcbf
 
 .PHONY: phpstan
 phpstan:
@@ -25,7 +25,7 @@ phpstan:
 
 .PHONY: psalm
 psalm:
-	docker run -it --rm -v${PWD}:/opt/project -w /opt/project mickaelandrieu/psalm-ga
+	docker run -it --rm -v${PWD}:/opt/project -w /opt/project php:7.2 tools/psalm
 
 .PHONY: test
 test:
diff --git a/phive.xml b/phive.xml
index 76a2c6a..9eae695 100644
--- a/phive.xml
+++ b/phive.xml
@@ -2,4 +2,5 @@
 <phive xmlns="https://phar.io/phive">
   <phar name="phpunit" version="^8.4.3" installed="8.4.3" location="./tools/phpunit" copy="true"/>
   <phar name="phpstan" version="^0.9.1" installed="0.12.2" location="./tools/phpstan" copy="true"/>
+  <phar name="psalm" version="^3.12.1" installed="3.12.1" location="./tools/psalm" copy="true"/>
 </phive>
diff --git a/src/DocBlock/StandardTagFactory.php b/src/DocBlock/StandardTagFactory.php
index 9a58c29..015a0d8 100644
--- a/src/DocBlock/StandardTagFactory.php
+++ b/src/DocBlock/StandardTagFactory.php
@@ -282,6 +282,8 @@ final class StandardTagFactory implements TagFactory
      * Retrieves a series of ReflectionParameter objects for the static 'create' method of the given
      * tag handler class name.
      *
+     * @param class-string $handlerClassName
+     *
      * @return ReflectionParameter[]
      */
     private function fetchParametersForHandlerFactoryMethod(string $handlerClassName) : array