mirrors/barryvdh_ReflectionDocBlock
1
0
Fork 0
mirror of https://github.com/barryvdh/ReflectionDocBlock.git synced 2026-08-18 01:57:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add support for constant types.

Browse Source 
phpstan supports contant definitions and expressions to
link to constants.
This commit is contained in:
Jaapio
2022-11-04 11:21:53 +01:00
parent 8d57d3da2d
commit 50bf16734e
8 changed files with 206 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/DocBlock/Tags/Factory/TagFactoryTestCase.php
+1 -1
View File
@@ -39,7 +39,7 @@ abstract class TagFactoryTestCase extends TestCase
public function giveTypeFactory(): TypeFactory
{
return new TypeFactory(new TypeResolver(new FqsenResolver()));
return new TypeFactory(new TypeResolver(new FqsenResolver()), new FqsenResolver());
}
public function givenDescriptionFactory(): DescriptionFactory
tests/unit/DocBlock/Tags/Factory/TypeFactoryTest.php
+21 -56
View File
@@ -15,8 +15,13 @@ namespace phpDocumentor\Reflection\DocBlock\Tags\Factory;
use phpDocumentor\Reflection\Fqsen;
use phpDocumentor\Reflection\FqsenResolver;
use phpDocumentor\Reflection\PseudoTypes\ConstExpression;
use phpDocumentor\Reflection\PseudoTypes\FloatValue;
use phpDocumentor\Reflection\PseudoTypes\IntegerRange;
use phpDocumentor\Reflection\PseudoTypes\IntegerValue;
use phpDocumentor\Reflection\PseudoTypes\List_;
use phpDocumentor\Reflection\PseudoTypes\StringValue;
use phpDocumentor\Reflection\PseudoTypes\True_;
use phpDocumentor\Reflection\Type;
use phpDocumentor\Reflection\TypeResolver;
use phpDocumentor\Reflection\Types\Array_;
@@ -50,6 +55,8 @@ final class TypeFactoryTest extends TestCase
* @dataProvider typeProvider
* @dataProvider genericsProvider
* @dataProvider callableProvider
* @dataProvider constExpressions
* @testdox create type from $type
*/
public function testTypeBuilding(string $type, Type $expected): void
{
@@ -58,8 +65,9 @@ final class TypeFactoryTest extends TestCase
$constParser = new ConstExprParser();
$parser = new TypeParser($constParser);
$ast = $parser->parse(new TokenIterator($tokens));
$fqsenResolver = new FqsenResolver();
$factory = new TypeFactory(new TypeResolver(new FqsenResolver()));
$factory = new TypeFactory(new TypeResolver($fqsenResolver), $fqsenResolver);
$actual = $factory->createType($ast, new Context('phpDocumentor'));
self::assertEquals($expected, $actual);
@@ -219,72 +227,29 @@ final class TypeFactoryTest extends TestCase
public function constExpressions(): array
{
return [
['Foo::FOO_CONSTANT'],
[
'123',
//new ConstTypeNode(new ConstExprIntegerNode('123')),
new IntegerValue(123),
],
[
'true',
new True_(),
],
[
'123.2',
//new ConstTypeNode(new ConstExprFloatNode('123.2')),
new FloatValue(123.2),
],
[
'"bar"',
//new ConstTypeNode(new ConstExprStringNode('bar')),
new StringValue('bar'),
],
[
'Foo::FOO_CONSTANT',
new ConstExpression(new Fqsen('\\phpDocumentor\\Foo'), 'FOO_CONSTANT'),
],
[
'Foo::FOO_*',
//new ConstTypeNode(new ConstFetchNode('Foo', 'FOO_*')),
],
[
'Foo::FOO_*BAR',
//new ConstTypeNode(new ConstFetchNode('Foo', 'FOO_*BAR')),
],
[
'Foo::*FOO*',
//new ConstTypeNode(new ConstFetchNode('Foo', '*FOO*')),
],
[
'Foo::A*B*C',
//new ConstTypeNode(new ConstFetchNode('Foo', 'A*B*C')),
],
[
'self::*BAR',
//new ConstTypeNode(new ConstFetchNode('self', '*BAR')),
],
[
'Foo::*',
//new ConstTypeNode(new ConstFetchNode('Foo', '*')),
],
[
'Foo::**',
//new ConstTypeNode(new ConstFetchNode('Foo', '*')), // fails later in PhpDocParser
//Lexer::TOKEN_WILDCARD,
],
[
'Foo::*a',
//new ConstTypeNode(new ConstFetchNode('Foo', '*a')),
],
[
'( "foo" | Foo::FOO_* )',
// new UnionTypeNode([
// new ConstTypeNode(new ConstExprStringNode('foo')),
// new ConstTypeNode(new ConstFetchNode('Foo', 'FOO_*')),
// ]),
],
[
'DateTimeImmutable::*|DateTime::*',
// new UnionTypeNode([
// new ConstTypeNode(new ConstFetchNode('DateTimeImmutable', '*')),
// new ConstTypeNode(new ConstFetchNode('DateTime', '*')),
// ]),
],
[
'ParameterTier::*|null',
// new UnionTypeNode([
// new ConstTypeNode(new ConstFetchNode('ParameterTier', '*')),
// new IdentifierTypeNode('null'),
// ]),
new ConstExpression(new Fqsen('\\phpDocumentor\\Foo'), 'FOO_*'),
],
];
}