🚸 code review

This commit is contained in:
Gautier DELEGLISE
2024-10-30 21:49:01 +01:00
parent 93cfc743bd
commit 6a623a4829
2 changed files with 25 additions and 9 deletions
@@ -17,10 +17,16 @@ use phpDocumentor\Reflection\DocBlock\Tags\Formatter;
use function str_repeat; use function str_repeat;
use function strlen; use function strlen;
class MethodParameterFactory /**
* @internal This class is not part of the BC promise of this library.
*/
final class MethodParameterFactory
{ {
/** /**
* Formats the given default value to a string-able mixin * Formats the given default value to a string-able mixin
*
* @param mixed $defaultValue
* @return string
*/ */
public function format($defaultValue): string public function format($defaultValue): string
{ {
@@ -30,32 +36,36 @@ class MethodParameterFactory
return ''; return '';
} }
protected function formatDouble(float $defaultValue): string private function formatDouble(float $defaultValue): string
{ {
return var_export($defaultValue, true); return var_export($defaultValue, true);
} }
protected function formatNull($defaultValue): string /**
* @param mixed $defaultValue
* @return string
*/
private function formatNull($defaultValue): string
{ {
return 'null'; return 'null';
} }
protected function formatInteger(int $defaultValue): string private function formatInteger(int $defaultValue): string
{ {
return var_export($defaultValue, true); return var_export($defaultValue, true);
} }
protected function formatString(string $defaultValue): string private function formatString(string $defaultValue): string
{ {
return var_export($defaultValue, true); return var_export($defaultValue, true);
} }
protected function formatBoolean(bool $defaultValue): string private function formatBoolean(bool $defaultValue): string
{ {
return var_export($defaultValue, true); return var_export($defaultValue, true);
} }
protected function formatArray(array $defaultValue): string private function formatArray(array $defaultValue): string
{ {
$formatedValue = '['; $formatedValue = '[';
@@ -74,7 +84,7 @@ class MethodParameterFactory
return $formatedValue; return $formatedValue;
} }
protected function formatObject(object $defaultValue): string private function formatObject(object $defaultValue): string
{ {
return 'new '. get_class($defaultValue). '()'; return 'new '. get_class($defaultValue). '()';
} }
+7 -1
View File
@@ -25,10 +25,16 @@ final class MethodParameter
private string $name; private string $name;
private mixed $defaultValue; /**
* @var mixed
*/
private $defaultValue;
private const NO_DEFAULT_VALUE = '__NO_VALUE__'; private const NO_DEFAULT_VALUE = '__NO_VALUE__';
/**
* @param mixed $defaultValue
*/
public function __construct( public function __construct(
string $name, string $name,
Type $type, Type $type,