Reverted the move of explode() into Return, and moved the implode() into Collection's new __toString() method instead;

Also had to made type resolution lazy, as a pleasant side effect.

This reverts commit db20ae39fb.
This commit is contained in:
Vasil Rangelov
2012-11-18 18:50:45 +02:00
parent 39faeec91d
commit 9da4a65065
3 changed files with 64 additions and 33 deletions
@@ -148,9 +148,7 @@ class CollectionTest extends \PHPUnit_Framework_TestCase
$collection = new Collection();
$collection->setNamespace('\My\Space');
$collection->setNamespaceAliases(array('Alias' => '\My\Space\Aliasing'));
foreach ($fixture as $type) {
$collection->add($type);
}
$collection->add($fixture);
$this->assertSame($expected, $collection->getArrayCopy());
}
@@ -168,9 +166,7 @@ class CollectionTest extends \PHPUnit_Framework_TestCase
{
$collection = new Collection();
$collection->setNamespaceAliases(array('Alias' => '\My\Space\Aliasing'));
foreach ($fixture as $type) {
$collection->add($type);
}
$collection->add($fixture);
$this->assertSame($expected, $collection->getArrayCopy());
}
@@ -199,34 +195,34 @@ class CollectionTest extends \PHPUnit_Framework_TestCase
public function provideTypesToExpand($method, $namespace = '\My\Space\\')
{
return array(
array(array(''), array()),
array(array(' '), array()),
array(array('int'), array('int')),
array(array('int '), array('int')),
array(array('string'), array('string')),
array(array('DocBlock'), array($namespace.'DocBlock')),
array(array('DocBlock[]'), array($namespace.'DocBlock[]')),
array(array(' DocBlock '), array($namespace.'DocBlock')),
array(array('\My\Space\DocBlock'), array('\My\Space\DocBlock')),
array(array('Alias\DocBlock'), array('\My\Space\Aliasing\DocBlock')),
array('', array()),
array(' ', array()),
array('int', array('int')),
array('int ', array('int')),
array('string', array('string')),
array('DocBlock', array($namespace.'DocBlock')),
array('DocBlock[]', array($namespace.'DocBlock[]')),
array(' DocBlock ', array($namespace.'DocBlock')),
array('\My\Space\DocBlock', array('\My\Space\DocBlock')),
array('Alias\DocBlock', array('\My\Space\Aliasing\DocBlock')),
array(
array('DocBlock', 'Tag'),
'DocBlock|Tag',
array($namespace .'DocBlock', $namespace .'Tag')
),
array(
array('DocBlock', 'null'),
'DocBlock|null',
array($namespace.'DocBlock', 'null')
),
array(
array('\My\Space\DocBlock', 'Tag'),
'\My\Space\DocBlock|Tag',
array('\My\Space\DocBlock', $namespace.'Tag')
),
array(
array('DocBlock[]', 'null'),
'DocBlock[]|null',
array($namespace.'DocBlock[]', 'null')
),
array(
array('DocBlock[]', 'int[]'),
'DocBlock[]|int[]',
array($namespace.'DocBlock[]', 'int[]')
),
);