From e65d30b27adcc44ae557c4dc106ace3f82a280df Mon Sep 17 00:00:00 2001 From: Markus Podar Date: Mon, 5 Feb 2024 06:54:43 +0100 Subject: [PATCH] Remove doctrine/dbal:^4 support (#1507) * Remove doctrine/dbal:^4 support Tests fail with: `PHP Fatal error: Declaration of Illuminate\Database\PDO\Concerns\ConnectsToDatabase::connect(array $params, $username = null, $password = null, array $driverOptions = []) must be compatible with Doctrine\DBAL\Driver::connect(array $params): Doctrine\DBAL\Driver\Connection in /home/runner/work/laravel-ide-helper/laravel-ide-helper/vendor/laravel/framework/src/Illuminate/Database/PDO/Concerns/ConnectsToDatabase.php on line 22` * gha: install with downgrading all dependencies * Add note to readme --- .github/workflows/run-integration-tests.yml | 2 +- README.md | 4 ++++ composer.json | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/run-integration-tests.yml b/.github/workflows/run-integration-tests.yml index 31bc718..84345c5 100644 --- a/.github/workflows/run-integration-tests.yml +++ b/.github/workflows/run-integration-tests.yml @@ -62,7 +62,7 @@ jobs: run: | cd sample sed -e 's|"type": "project",|&\n"repositories": [ { "type": "path", "url": "../src" } ],|' -i composer.json - composer require --dev "barryvdh/laravel-ide-helper:*" + composer require --dev "barryvdh/laravel-ide-helper:*" --with-all-dependencies - name: Execute generate run run: | diff --git a/README.md b/README.md index 92f04fa..7050d13 100644 --- a/README.md +++ b/README.md @@ -33,6 +33,10 @@ Require this package with composer using the following command: composer require --dev barryvdh/laravel-ide-helper ``` +> [!NOTE] +> If you encounter version conflicts with doctrine/dbal, please try: +> `composer require --dev barryvdh/laravel-ide-helper --with-all-dependencies` + This package makes use of [Laravels package auto-discovery mechanism](https://medium.com/@taylorotwell/package-auto-discovery-in-laravel-5-5-ea9e3ab20518), which means if you don't install dev dependencies in production, it also won't be loaded. If for some reason you want manually control this: diff --git a/composer.json b/composer.json index 22d94d8..ef72894 100644 --- a/composer.json +++ b/composer.json @@ -24,7 +24,7 @@ "ext-json": "*", "barryvdh/reflection-docblock": "^2.0.6", "composer/class-map-generator": "^1.0", - "doctrine/dbal": "^2.6 || ^3 || ^4", + "doctrine/dbal": "^2.6 || ^3", "illuminate/console": "^8 || ^9 || ^10", "illuminate/filesystem": "^8 || ^9 || ^10", "illuminate/support": "^8 || ^9 || ^10",