done

.github/workflows/ci.yml

@@ -99,7 +99,7 @@ jobs:
     runs-on: windows-2019
     defaults:
       run:
-        shell: cmd # TODO: does this matter?
+        shell: cmd # use CMD instead of powershell to catch error from bat script
     strategy:
       matrix:
         arch: [x64]
@@ -118,6 +118,7 @@ jobs:
       with:
         arch: ${{ matrix.arch }}
         toolset: ${{steps.setup-php-sdk.outputs.toolset}}
+    # CMD only execute one commend per run
     - run: phpize
     - run: .\configure --with-prefix=${{steps.setup-php-sdk.outputs.prefix}} --enable-awscrt=shared --enable-cli --enable-openssl
     - run: nmake

Makefile.frag.w32

@@ -27,5 +27,5 @@ $(AWSCRT_DIR)\ext\api.h: $(AWSCRT_DIR)\crt\aws-crt-ffi\src\api.h
 # Get the dll directory to load
 generate-php-ini:
 	@echo extension=$(BUILD_DIR)\php_awscrt.dll > php-win.ini
-	@echo extension=$(PHP_PREFIX)\php_openssl.dll >> php-win.ini
+	@echo extension=$(PHP_PREFIX)\ext\php_openssl.dll >> php-win.ini
 	@echo extension=$(PHP_PREFIX)\ext\php_mbstring.dll >> php-win.ini